extensions/browser/guest_view/test_guest_view_manager.h - Issue 890183002: Allow Signin page to open other chrome:// URLs if login content in <webview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/test_guest_view_manager.h

Issue 890183002: Allow Signin page to open other chrome:// URLs if login content in <webview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/teardown/test.js ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/test_guest_view_manager.h

diff --git a/extensions/browser/guest_view/test_guest_view_manager.h b/extensions/browser/guest_view/test_guest_view_manager.h

index 283eabba9970f5b9a57360c36c776de65e1bd047..b826f30ff5af9a075c7fc6ec7f334810735b5988 100644

--- a/extensions/browser/guest_view/test_guest_view_manager.h

+++ b/extensions/browser/guest_view/test_guest_view_manager.h

@@ -21,6 +21,8 @@ class TestGuestViewManager : public GuestViewManager {

void WaitForAllGuestsDeleted();

content::WebContents* WaitForSingleGuestCreated();

+ content::WebContents* GetLastGuestCreated();

private:

// GuestViewManager override:

void AddGuest(int guest_instance_id,

@@ -28,7 +30,6 @@ class TestGuestViewManager : public GuestViewManager {

void RemoveGuest(int guest_instance_id) override;

int GetNumGuests() const;

- content::WebContents* GetLastGuestCreated();

void WaitForGuestCreated();

std::vector<linked_ptr<content::WebContentsDestroyedWatcher>>