Allow Signin page to open other chrome:// URLs if login content in <webview>

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 1003 matching lines @@
   GURL from_url = site_instance->GetSiteURL();
 
 #if defined(ENABLE_EXTENSIONS)
   bool result;
   if (ChromeContentBrowserClientExtensionsPart::ShouldAllowOpenURL(
       site_instance, from_url, url, &result))
     return result;
 #endif
 
   // Do not allow chrome://chrome-signin navigate to other chrome:// URLs, since
-  // the signin page may host untrusted web content.
-  if (from_url.GetOrigin().spec() == chrome::kChromeUIChromeSigninURL &&
+  // the signin page may host untrusted web content unless <webview>-based

[Charlie Reis, 2015/02/02 17:29:21]

This comment is a bit hard to follow.  Maybe:

...since the signin page may host untrusted web content when <webview>-based
signin is not enabled.  In the <webview> case, untrusted content is
out-of-process and cannot navigate to chrome:// URLs.

[Fady Samuel, 2015/02/02 19:59:07]

Done.

+  // signin is enabled. In this case, untrusted content cannot directly access
+  // other chrome:// URLs.
+  if (!switches::IsEnableWebviewBasedSignin() &&
+      from_url.GetOrigin().spec() == chrome::kChromeUIChromeSigninURL &&
       url.SchemeIs(content::kChromeUIScheme) &&
       url.host() != chrome::kChromeUIChromeSigninHost) {
     VLOG(1) << "Blocked navigation to " << url.spec() << " from "
             << chrome::kChromeUIChromeSigninURL;
     return false;
   }
 
   return true;
 }
 
@@ skipping 1611 matching lines @@
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)
 
 }  // namespace chrome