Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 890173003: Replace the sample Calendar extension with a deprecation notice (Closed)

Created:
5 years, 10 months ago by not at google - send to devlin
Modified:
5 years, 10 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace the sample Calendar extension with a deprecation notice linking to a working (also By Google) Calendar extension. BUG=435290 R=aboxhall@chromium.org NOTRY=true Committed: https://crrev.com/8a9227c890e05dd05adbebd00523222107e82919 Cr-Commit-Position: refs/heads/master@{#314075}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -907 lines) Patch
D chrome/common/extensions/docs/examples/extensions/calendar/images/calendar_logo.gif View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/extensions/calendar/images/icon-128.gif View Binary file 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/images/icon-128.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/extensions/calendar/images/icon-16.gif View Binary file 0 comments Download
A + chrome/common/extensions/docs/examples/extensions/calendar/images/icon-16.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/extensions/calendar/images/icon-16_bw.gif View Binary file 0 comments Download
A + chrome/common/extensions/docs/examples/extensions/calendar/images/icon-19.png View Binary file 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/images/icon-38.png View Binary file 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/images/icon-48.png View Binary file 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calendar/javascript/background.js View 1 chunk +28 lines, -738 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calendar/javascript/options.js View 1 chunk +8 lines, -56 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/calendar/javascript/util.js View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calendar/manifest.json View 1 chunk +16 lines, -7 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/calendar/views/background.html View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calendar/views/options.html View 1 1 chunk +16 lines, -76 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
not at google - send to devlin
5 years, 10 months ago (2015-02-01 00:22:43 UTC) #1
aboxhall
lgtm
5 years, 10 months ago (2015-02-01 00:32:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890173003/20001
5 years, 10 months ago (2015-02-01 00:33:28 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-01 00:34:19 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-01 00:35:16 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a9227c890e05dd05adbebd00523222107e82919
Cr-Commit-Position: refs/heads/master@{#314075}

Powered by Google App Engine
This is Rietveld 408576698