Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 890113002: Remove SigninManager.isNewProfileManagementEnabled(). (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
Reviewers:
aruslan
CC:
chromium-reviews, Mike Lerman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SigninManager.isNewProfileManagementEnabled(). This method is no longer used. All Android code assumes that new profile management is enabled. BUG=393335 R=aruslan@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5778babeb264211044c1ff1ef6d2e41f07e341b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -29 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/android/signin/signin_manager_android.cc View 2 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
newt (away)
PTAL I meant to send this out a while ago and just forgot about it.
5 years, 10 months ago (2015-01-31 02:17:42 UTC) #2
aruslan
lgtm thanks!
5 years, 10 months ago (2015-01-31 02:37:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890113002/1
5 years, 10 months ago (2015-01-31 02:46:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (None)
5 years, 10 months ago (2015-01-31 04:48:44 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5778babeb264211044c1ff1ef6d2e41f07e341b4 Cr-Commit-Position: refs/heads/master@{#314252}
5 years, 10 months ago (2015-02-03 02:48:50 UTC) #8
newt (away)
5 years, 10 months ago (2015-02-03 02:48:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5778babeb264211044c1ff1ef6d2e41f07e341b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698