Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 890103002: [android] Remove libaddressinput Java widget. (Closed)

Created:
5 years, 10 months ago by please use gerrit instead
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Remove libaddressinput Java widget. Android uses a custom UI with the cross-platform strings for address input. BUG=454120 Committed: https://crrev.com/e7e8b5f5a53c3577b84413bd165731ca66d6a837 Cr-Commit-Position: refs/heads/master@{#314217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -234 lines) Patch
D chrome/app/address_input_strings_android.grd View 1 chunk +0 lines, -66 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 1 chunk +58 lines, -131 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
please use gerrit instead
Evan, PTAL.
5 years, 10 months ago (2015-01-31 20:11:03 UTC) #2
Evan Stade
lgtm
5 years, 10 months ago (2015-02-02 18:17:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890103002/1
5 years, 10 months ago (2015-02-02 19:16:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39874)
5 years, 10 months ago (2015-02-02 19:23:09 UTC) #7
please use gerrit instead
Carlos, OWNERS PTAL chrome/app/address_input_strings_android.grd. (Evan and I are OWNERS of chrome/app/address_input_strings*, but the script seems ...
5 years, 10 months ago (2015-02-02 19:35:33 UTC) #9
cpu_(ooo_6.6-7.5)
lgtm strange, grd changes are TBR, the owner file should say so
5 years, 10 months ago (2015-02-02 23:01:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890103002/1
5 years, 10 months ago (2015-02-02 23:11:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 23:15:12 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e7e8b5f5a53c3577b84413bd165731ca66d6a837 Cr-Commit-Position: refs/heads/master@{#314217}
5 years, 10 months ago (2015-02-02 23:15:56 UTC) #14
perezju
5 years, 10 months ago (2015-02-03 13:37:35 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/892403002/ by perezju@chromium.org.

The reason for reverting is: This CL broke the gn android build.

To reproduce locally on a chromium checkout src:

> gn gen --args='os="android" cpu_arch="arm" use_goma=true' out_android_gn/Debug
> ninja -C out_android_gn/Debug

eventually fails with:

[6011/25521] CXX
obj/third_party/libaddressinput/chromium/libaddressinput.chrome_address_validator.o
<snip>
../../third_party/libaddressinput/chromium/chrome_address_validator.cc:156:68:
error: call of overloaded 'pow(int, int)' is ambiguous
       GetBaseRetryPeriod() * pow(2, attempts_number_[region_code]++));
.

Powered by Google App Engine
This is Rietveld 408576698