Issue 890093002: Clean up HttpServerPropertiesManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 890093002: Clean up HttpServerPropertiesManager (Closed)

Created:
5 years, 10 months ago by Ryan Hamilton

Modified:
5 years, 10 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Factor several helper methods out of UpdateCacheFromPrefsOnPrefThread and UpdatePrefsOnPrefThread. Factor out key strings into variables. Committed: https://crrev.com/5ac594b1f57bc3a74e7dc1569733a3552afff2ac Cr-Commit-Position: refs/heads/master@{#314401}

Patch Set 1 #

Patch Set 2 : More! #

Patch Set 3 : Rebase #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+260 lines, -214 lines)			Patch
	M	net/http/http_server_properties_manager.h	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download
	M	net/http/http_server_properties_manager.cc	View	1 2	12 chunks	+236 lines, -214 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ramant (doing other things)

lgtm Awesome (long over due). Thanks for doing this.

5 years, 10 months ago (2015-02-03 18:25:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890093002/40001

5 years, 10 months ago (2015-02-03 18:45:17 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-03 20:37:59 UTC) #6

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/5ac594b1f57bc3a74e7dc1569733a3552afff2ac
Cr-Commit-Position: refs/heads/master@{#314401}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages