extensions/browser/process_manager.cc - Issue 890083002: [Extensions] Propagate activeTab hosts to extension background pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/process_manager.cc

Issue 890083002: [Extensions] Propagate activeTab hosts to extension background pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/process_manager.cc

diff --git a/extensions/browser/process_manager.cc b/extensions/browser/process_manager.cc

index 83bd2cdcd6f2cd5671da46ab051878227a8878f3..8c759ff26a10361df0bfb949fc7cfdff245d693b 100644

--- a/extensions/browser/process_manager.cc

+++ b/extensions/browser/process_manager.cc

@@ -378,9 +378,9 @@ std::set<RenderViewHost*> ProcessManager::GetRenderViewHostsForExtension(

const std::string& extension_id) {

std::set<RenderViewHost*> result;

- SiteInstance* site_instance = GetSiteInstanceForURL(

- Extension::GetBaseURLFromExtensionId(extension_id));

- if (!site_instance)

+ scoped_refptr<SiteInstance> site_instance(GetSiteInstanceForURL(

+ Extension::GetBaseURLFromExtensionId(extension_id)));

+ if (!site_instance.get())

return result;

// Gather up all the views for that site.

« no previous file with comments | « extensions/browser/process_manager.h ('k') | extensions/browser/renderer_startup_helper.cc » ('j') | no next file with comments »