Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: extensions/common/permissions/permissions_data.h

Issue 890083002: [Extensions] Propagate activeTab hosts to extension background pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permissions_data.h
diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h
index ba2f3c3aa54078bbca0e1843e7fc2ec9942e3e70..74af40e9d10f078649609a3cd4c53148995b5e4b 100644
--- a/extensions/common/permissions/permissions_data.h
+++ b/extensions/common/permissions/permissions_data.h
@@ -115,15 +115,16 @@ class PermissionsData {
APIPermission::ID permission,
const APIPermission::CheckParam* param) const;
- // TODO(rdevlin.cronin): GetEffectiveHostPermissions(), HasHostPermission(),
- // and HasEffectiveAccessToAllHosts() are just forwards for the active
+ // Returns the effective hosts associated with the active permissions and the
+ // current tab permissions.
+ URLPatternSet GetEffectiveHostPermissions() const;
+
+ // TODO(rdevlin.cronin): HasHostPermission() and
+ // HasEffectiveAccessToAllHosts() are just forwards for the active
// permissions. We should either get rid of these, and have callers use
// active_permissions(), or should get rid of active_permissions(), and make
// callers use PermissionsData for everything. We should not do both.
- // Returns the effective hosts associated with the active permissions.
- const URLPatternSet& GetEffectiveHostPermissions() const;
-
// Whether the extension has access to the given |url|.
bool HasHostPermission(const GURL& url) const;

Powered by Google App Engine
This is Rietveld 408576698