[Extensions] Propagate activeTab hosts to extension background pages

extensions/common/extension_messages.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_messages.h"
 
 #include "content/public/common/common_param_traits.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_handler.h"
@@ skipping 31 matching lines @@
       apis, manifest_permissions, explicit_hosts, scriptable_hosts);
 }
 
 ExtensionMsg_Loaded_Params::ExtensionMsg_Loaded_Params()
     : location(Manifest::INVALID_LOCATION),
       creation_flags(Extension::NO_FLAGS) {}
 
 ExtensionMsg_Loaded_Params::~ExtensionMsg_Loaded_Params() {}
 
 ExtensionMsg_Loaded_Params::ExtensionMsg_Loaded_Params(
-    const Extension* extension)
+    const Extension* extension,
+    bool include_tab_permissions)
     : manifest(extension->manifest()->value()->DeepCopy()),
       location(extension->location()),
       path(extension->path()),
       active_permissions(*extension->permissions_data()->active_permissions()),
       withheld_permissions(
           *extension->permissions_data()->withheld_permissions()),
       id(extension->id()),
       creation_flags(extension->creation_flags()) {
+  if (include_tab_permissions) {
+    const extensions::PermissionsData::TabPermissionsMap& tab_permissions =
+        extension->permissions_data()->tab_specific_permissions();
+    for (const auto& pair : tab_permissions) {
+      tab_specific_permissions[pair.first] =
+          ExtensionMsg_PermissionSetStruct(*pair.second);
+    }
+  }
 }
 
 scoped_refptr<Extension> ExtensionMsg_Loaded_Params::ConvertToExtension(
     std::string* error) const {
   scoped_refptr<Extension> extension =
       Extension::Create(path, location, *manifest, creation_flags, error);
   if (extension.get()) {
-    extension->permissions_data()->SetPermissions(
-        active_permissions.ToPermissionSet(),
-        withheld_permissions.ToPermissionSet());
+    const extensions::PermissionsData* permissions_data =
+        extension->permissions_data();
+    permissions_data->SetPermissions(active_permissions.ToPermissionSet(),
+                                     withheld_permissions.ToPermissionSet());
+    for (const auto& pair : tab_specific_permissions) {

[not at google - send to devlin, 2015/02/05 00:16:13]

Should only really do this if |include_tab_permissions| is true, much as it
makes no difference, symmetry is nice.

[Devlin, 2015/02/05 19:54:50]

But then we have to cache include_tab_permissions, and that also means sending
it across IPC.  Is the symmetry worth it?  Or can we just say that the fact that
tab_specific_permissions is/isn't empty is an indication that tab permissions
weren't/were included?

[not at google - send to devlin, 2015/02/05 22:40:22]

Oh, you're not saving it... good point. Yes just say that.

+      permissions_data->UpdateTabSpecificPermissions(
+          pair.first, pair.second.ToPermissionSet());
+    }
   }
   return extension;
 }
 
 namespace IPC {
 
 template <>
 struct ParamTraits<Manifest::Location> {
   typedef Manifest::Location param_type;
   static void Write(Message* m, const param_type& p) {
@@ skipping 199 matching lines @@
          ReadParam(m, iter, &p->active_permissions) &&
          ReadParam(m, iter, &p->withheld_permissions);
 }
 
 void ParamTraits<ExtensionMsg_Loaded_Params>::Log(const param_type& p,
                                                   std::string* l) {
   l->append(p.id);
 }
 
 }  // namespace IPC