Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 890073002: Update dump code in FontConfigParser test. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
mtklein, djsollen, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update dump code in FontConfigParser test. This code is still quite useful for debugging, but has bit rotted. Update to match current structure of code. Committed: https://skia.googlesource.com/skia/+/a44e9b9842c8b1f68803171bff8695fa10312b5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M tests/FontConfigParser.cpp View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
5 years, 10 months ago (2015-01-30 23:41:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890073002/1
5 years, 10 months ago (2015-01-30 23:42:26 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-30 23:42:27 UTC) #5
tomhudson
lgtm
5 years, 10 months ago (2015-01-31 03:57:23 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-31 03:58:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a44e9b9842c8b1f68803171bff8695fa10312b5c

Powered by Google App Engine
This is Rietveld 408576698