Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 890043003: roll gyp 2029:2030 (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

roll gyp 2029:2030 r2030: win: Add NoImportLibrary flag for ninja generator TBR=grt@chromium.org BUG=451499 Committed: https://crrev.com/7a47c4214a06aa1778ced28dc6c57658326bbf3d Cr-Commit-Position: refs/heads/master@{#314000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 10 months ago (2015-01-30 20:46:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890043003/1
5 years, 10 months ago (2015-01-30 20:48:16 UTC) #3
grt (UTC plus 2)
lgtm
5 years, 10 months ago (2015-01-30 20:48:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 21:49:57 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 21:51:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a47c4214a06aa1778ced28dc6c57658326bbf3d
Cr-Commit-Position: refs/heads/master@{#314000}

Powered by Google App Engine
This is Rietveld 408576698