Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 890033003: Revert of [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var (Closed)

Created:
5 years, 10 months ago by please use gerrit instead
Modified:
5 years, 10 months ago
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var (patchset #5 id:80001 of https://codereview.chromium.org/737653003/) Reason for revert: Broke compile on Google Chrome ChromeOS bot. [8069/19495] CXX obj/components/policy/core/common/cloud/policy_component_common.external_policy_data_updater.o FAILED: cd ../../third_party/liblouis; python ../../native_client_sdk/src/tools/create_nmf.py ../../out/Release/chromevox_test_data/braille/liblouis_nacl_x86_64.nexe "--output=../../out/Release/chromevox_test_data/braille/liblouis_nacl.nmf" Traceback (most recent call last): File "../../native_client_sdk/src/tools/create_nmf.py", line 680, in <module> rtn = main(sys.argv[1:]) File "../../native_client_sdk/src/tools/create_nmf.py", line 633, in main options.lib_path += GetDefaultLibPath(config) File "../../native_client_sdk/src/tools/create_nmf.py", line 507, in GetDefaultLibPath sdk_root = GetSDKRoot() File "../../native_client_sdk/src/tools/create_nmf.py", line 478, in GetSDKRoot assert(os.path.exists(os.path.join(sdk_root, 'toolchain'))) AssertionError ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/76569 Original issue's description: > [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var > > create_nmf should determine the root of the SDK relative > to its own location. > > The exception to this is when its run as part of the > chrome build, when it is not yet installed. In this > case we pass --no-default-libpath and --objdump to > create_nmf to remove any use of the SDK root. > > Committed: https://crrev.com/088561ac99314a79866a39f79bb32bd5e1196217 > Cr-Commit-Position: refs/heads/master@{#313957} TBR=binji@chromium.org,dmichael@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/243315bb066856bcadc20b3118ec623d96187edd Cr-Commit-Position: refs/heads/master@{#313963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M native_client_sdk/src/tools/create_nmf.py View 5 chunks +21 lines, -14 lines 0 comments Download
M native_client_sdk/src/tools/tests/create_nmf_test.py View 2 chunks +15 lines, -11 lines 0 comments Download
M ppapi/ppapi_nacl.gyp View 6 chunks +2 lines, -8 lines 0 comments Download
M ppapi/ppapi_nacl_test_common.gypi View 5 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
please use gerrit instead
Created Revert of [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var
5 years, 10 months ago (2015-01-30 19:34:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890033003/1
5 years, 10 months ago (2015-01-30 19:35:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 19:37:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/243315bb066856bcadc20b3118ec623d96187edd Cr-Commit-Position: refs/heads/master@{#313963}
5 years, 10 months ago (2015-01-30 19:37:59 UTC) #4
Sam Clegg
lgtm. Why did the trybots find this?
5 years, 10 months ago (2015-01-30 20:24:09 UTC) #5
please use gerrit instead
5 years, 10 months ago (2015-01-30 20:28:42 UTC) #6
Message was sent while issue was closed.
Not sure.

Powered by Google App Engine
This is Rietveld 408576698