Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 890023004: Clean up core.gyp (Closed)

Created:
5 years, 10 months ago by tasak
Modified:
5 years, 10 months ago
Reviewers:
haraken, brettw
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up core.gyp. Since core.gyp uses both includes and excludes rule, it is a little dirty and difficult to read. Instead, we should explicitly exclude platform-specific files from one global file list. BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189773

Patch Set 1 #

Patch Set 2 : WIP: "includes" way #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1025 lines, -1040 lines) Patch
M Source/core/BUILD.gn View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/core.gni View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/core.gyp View 1 2 3 7 chunks +35 lines, -56 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 3 chunks +984 lines, -982 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tasak
Would you review this CL?
5 years, 10 months ago (2015-02-06 11:28:10 UTC) #2
brettw
Probably a Blink reviewer will be more appropriate. The GN changes are trivial and would ...
5 years, 10 months ago (2015-02-06 16:36:03 UTC) #3
haraken
LGTM https://codereview.chromium.org/890023004/diff/40001/Source/core/core.gypi File Source/core/core.gypi (right): https://codereview.chromium.org/890023004/diff/40001/Source/core/core.gypi#newcode848 Source/core/core.gypi:848: 'webcore_remaining_files': [ I'm not sure if webcore_"remaining"_files is ...
5 years, 10 months ago (2015-02-08 01:44:07 UTC) #4
tasak
Thank you for review. https://codereview.chromium.org/890023004/diff/40001/Source/core/core.gypi File Source/core/core.gypi (right): https://codereview.chromium.org/890023004/diff/40001/Source/core/core.gypi#newcode848 Source/core/core.gypi:848: 'webcore_remaining_files': [ On 2015/02/08 01:44:07, ...
5 years, 10 months ago (2015-02-09 01:56:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890023004/60001
5 years, 10 months ago (2015-02-09 02:18:55 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 03:38:29 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189773

Powered by Google App Engine
This is Rietveld 408576698