Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 890013004: Check Ahem font ex units on multiple platforms. (Closed)

Created:
5 years, 10 months ago by Erik Dahlström (inactive)
Modified:
5 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check Ahem font ex units on multiple platforms. BUG=441840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191427

Patch Set 1 #

Patch Set 2 : mac test suppresssion #

Total comments: 2

Patch Set 3 : add float tolerance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/cssom/ahem-ex-units.html View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/cssom/ahem-ex-units-expected.txt View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Erik Dahlström (inactive)
5 years, 9 months ago (2015-03-05 11:20:01 UTC) #2
eae
LGTM w/nit https://codereview.chromium.org/890013004/diff/20001/LayoutTests/cssom/ahem-ex-units.html File LayoutTests/cssom/ahem-ex-units.html (right): https://codereview.chromium.org/890013004/diff/20001/LayoutTests/cssom/ahem-ex-units.html#newcode37 LayoutTests/cssom/ahem-ex-units.html:37: testComputed("word-spacing", "1ex", "12.8000001907349px"); I'd rather not add ...
5 years, 9 months ago (2015-03-05 19:39:44 UTC) #3
Erik Dahlström (inactive)
https://codereview.chromium.org/890013004/diff/20001/LayoutTests/cssom/ahem-ex-units.html File LayoutTests/cssom/ahem-ex-units.html (right): https://codereview.chromium.org/890013004/diff/20001/LayoutTests/cssom/ahem-ex-units.html#newcode37 LayoutTests/cssom/ahem-ex-units.html:37: testComputed("word-spacing", "1ex", "12.8000001907349px"); On 2015/03/05 19:39:44, eae wrote: > ...
5 years, 9 months ago (2015-03-06 09:05:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890013004/40001
5 years, 9 months ago (2015-03-06 09:05:41 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 11:42:59 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191427

Powered by Google App Engine
This is Rietveld 408576698