Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 890003003: Revert of Mark AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen as flaky (Closed)

Created:
5 years, 10 months ago by boliu
Modified:
5 years, 10 months ago
Reviewers:
Ted C, Ignacio Solla, Torne
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen as flaky. (patchset #1 id:1 of https://codereview.chromium.org/893533006/) Reason for revert: Root cause reverted (https://codereview.chromium.org/888903002/) so enabling test again. Not skipping cq Original issue's description: > Mark AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen as flaky. > > TBR=torne > NOTRY=true > BUG=453857 > > Committed: https://crrev.com/4be6e487bb78f3294657c9aca8ab13aaf641c2fa > Cr-Commit-Position: refs/heads/master@{#313946} TBR=torne@chromium.org,igsolla@chromium.org,tedchoc@chromium.org BUG=453857 Committed: https://crrev.com/a87e3a84d40ed1dc9ecc15ab9a7fec0ae167befa Cr-Commit-Position: refs/heads/master@{#313974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
boliu
Created Revert of Mark AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen as flaky.
5 years, 10 months ago (2015-01-30 19:39:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890003003/1
5 years, 10 months ago (2015-01-30 19:41:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 20:17:31 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 20:18:43 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a87e3a84d40ed1dc9ecc15ab9a7fec0ae167befa
Cr-Commit-Position: refs/heads/master@{#313974}

Powered by Google App Engine
This is Rietveld 408576698