Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 889983002: Revert of Update SSL/malware/net error interstitial design (Closed)

Created:
5 years, 10 months ago by perkj_chrome
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, felt
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update SSL/malware/net error interstitial design (patchset #3 id:40001 of https://codereview.chromium.org/882973003/) Reason for revert: revert_reason: Fails ChromeOS tests. ErrorPageTest.DNSError_DoClickLink ErrorPageTest.DNSError_DoReload https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55516 Original issue's description: > Update SSL/malware/net error interstitial design > + On small screens the navigation buttons are anchored to the bottom of the screen. > + Tweaks to the text colour > + Change button styling of safe browsing page > > BUG=422882 > > Committed: https://crrev.com/c2e35628285c2113775566cd85c52320e6fcf565 > Cr-Commit-Position: refs/heads/master@{#313910} TBR=arv@chromium.org,edwardjung@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=422882 Committed: https://crrev.com/0007e2ce97e9e43b78c44f996a21678b6180a71d Cr-Commit-Position: refs/heads/master@{#313921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -517 lines) Patch
M chrome/browser/resources/chromeos/neterror.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/offline_net_load.html View 2 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.css View 10 chunks +15 lines, -372 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.html View 1 chunk +17 lines, -22 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.js View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/browser/resources/security_warnings/interstitial_v2_mobile.js View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/resources/security_warnings/safe_browsing.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/resources/neterror.css View 6 chunks +7 lines, -12 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 2 chunks +54 lines, -54 lines 0 comments Download
M chrome/renderer/resources/neterror.js View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
perkj_chrome
Created Revert of Update SSL/malware/net error interstitial design
5 years, 10 months ago (2015-01-30 16:14:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889983002/1
5 years, 10 months ago (2015-01-30 16:15:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 16:16:52 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 16:18:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0007e2ce97e9e43b78c44f996a21678b6180a71d
Cr-Commit-Position: refs/heads/master@{#313921}

Powered by Google App Engine
This is Rietveld 408576698