Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 889963003: Revert of Update DEPS to better bootstrap 'cros_chromite.py' (Closed)

Created:
5 years, 10 months ago by dnj
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cmp-cc_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Revert of Update DEPS to better bootstrap 'cros_chromite.py' (patchset #1 id:1 of https://codereview.chromium.org/890803003/) Reason for revert: This is breaking 'gclient sync'. Original issue's description: > Update DEPS to better bootstrap 'cros_chromite.py' > > This fixes two problems with the current setup: > - The `runhooks' aren't being executed on slaves because the default > "recursion" value rules them out. > - The script is failing on Windows bots because the Python invocation > isn't working. > > BUG=414436 > TEST=local > - Ran in local context, seems to work. > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293879 TBR=petermayo@chromium.org,agable@chromium.org,sebmarchand@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=414436 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M DEPS View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dnj
Created Revert of Update DEPS to better bootstrap 'cros_chromite.py'
5 years, 10 months ago (2015-01-30 19:47:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889963003/1
5 years, 10 months ago (2015-01-30 19:48:15 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 19:48:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293881

Powered by Google App Engine
This is Rietveld 408576698