Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: Source/WebCore/dom/Document.cpp

Issue 8899006: Merge 102405 - Source/WebCore: Improve handling of frame removal during requestAnimationFrame cal... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/dom/Document.h ('k') | Source/WebCore/dom/ScriptedAnimationController.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * 10 *
(...skipping 591 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 removeAllChildren(); 602 removeAllChildren();
603 603
604 m_markers->detach(); 604 m_markers->detach();
605 605
606 detachParser(); 606 detachParser();
607 607
608 m_cssCanvasElements.clear(); 608 m_cssCanvasElements.clear();
609 609
610 #if ENABLE(REQUEST_ANIMATION_FRAME) 610 #if ENABLE(REQUEST_ANIMATION_FRAME)
611 // FIXME: consider using ActiveDOMObject. 611 // FIXME: consider using ActiveDOMObject.
612 m_scriptedAnimationController = nullptr; 612 if (m_scriptedAnimationController)
613 m_scriptedAnimationController->clearDocumentPointer();
614 m_scriptedAnimationController.clear();
613 #endif 615 #endif
614 616
615 #ifndef NDEBUG 617 #ifndef NDEBUG
616 m_inRemovedLastRefFunction = false; 618 m_inRemovedLastRefFunction = false;
617 #endif 619 #endif
618 620
619 guardDeref(); 621 guardDeref();
620 } else { 622 } else {
621 #ifndef NDEBUG 623 #ifndef NDEBUG
622 m_deletionHasBegun = true; 624 m_deletionHasBegun = true;
(...skipping 1191 matching lines...) Expand 10 before | Expand all | Expand 10 after
1814 clearAXObjectCache(); 1816 clearAXObjectCache();
1815 1817
1816 stopActiveDOMObjects(); 1818 stopActiveDOMObjects();
1817 m_eventQueue->close(); 1819 m_eventQueue->close();
1818 #if ENABLE(FULLSCREEN_API) 1820 #if ENABLE(FULLSCREEN_API)
1819 m_fullScreenChangeEventTargetQueue.clear(); 1821 m_fullScreenChangeEventTargetQueue.clear();
1820 #endif 1822 #endif
1821 1823
1822 #if ENABLE(REQUEST_ANIMATION_FRAME) 1824 #if ENABLE(REQUEST_ANIMATION_FRAME)
1823 // FIXME: consider using ActiveDOMObject. 1825 // FIXME: consider using ActiveDOMObject.
1824 m_scriptedAnimationController = nullptr; 1826 if (m_scriptedAnimationController)
1827 m_scriptedAnimationController->clearDocumentPointer();
1828 m_scriptedAnimationController.clear();
1825 #endif 1829 #endif
1826 1830
1827 RenderObject* render = renderer(); 1831 RenderObject* render = renderer();
1828 1832
1829 // Send out documentWillBecomeInactive() notifications to registered element s, 1833 // Send out documentWillBecomeInactive() notifications to registered element s,
1830 // in order to stop media elements 1834 // in order to stop media elements
1831 documentWillBecomeInactive(); 1835 documentWillBecomeInactive();
1832 1836
1833 #if ENABLE(SHARED_WORKERS) 1837 #if ENABLE(SHARED_WORKERS)
1834 SharedWorkerRepository::documentDetached(this); 1838 SharedWorkerRepository::documentDetached(this);
(...skipping 3348 matching lines...) Expand 10 before | Expand all | Expand 10 after
5183 5187
5184 NodeListsNodeData* data = rareData()->nodeLists(); 5188 NodeListsNodeData* data = rareData()->nodeLists();
5185 5189
5186 String localTypeNames = typeNames.isNull() ? String("http://webkit.org/micro data/undefinedItemType") : typeNames; 5190 String localTypeNames = typeNames.isNull() ? String("http://webkit.org/micro data/undefinedItemType") : typeNames;
5187 ASSERT_UNUSED(list, list == data->m_microDataItemListCache.get(localTypeName s)); 5191 ASSERT_UNUSED(list, list == data->m_microDataItemListCache.get(localTypeName s));
5188 data->m_microDataItemListCache.remove(localTypeNames); 5192 data->m_microDataItemListCache.remove(localTypeNames);
5189 } 5193 }
5190 #endif 5194 #endif
5191 5195
5192 } // namespace WebCore 5196 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/WebCore/dom/Document.h ('k') | Source/WebCore/dom/ScriptedAnimationController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698