Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889893002: Expose camera settings to the extensions. (Closed)

Created:
5 years, 10 months ago by msramek
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose camera settings to the extensions. BUG=453773 DIFFBASE=880223002 Committed: https://crrev.com/2b3079c96f41b136c66d787b3bfa39ee17084cd4 Cr-Commit-Position: refs/heads/master@{#314319}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Renamed to 'camera'. #

Patch Set 3 : Rebase over 880223002. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_helpers.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/content_settings.json View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_settings/standard/test.js View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
msramek
...and another one. This camera CL is based on the previous microphone one, so tests ...
5 years, 10 months ago (2015-01-30 11:57:57 UTC) #3
Mike West
LGTM. https://codereview.chromium.org/889893002/diff/20001/chrome/common/extensions/api/content_settings.json File chrome/common/extensions/api/content_settings.json (right): https://codereview.chromium.org/889893002/diff/20001/chrome/common/extensions/api/content_settings.json#newcode248 chrome/common/extensions/api/content_settings.json:248: "mediaStreamCamera": { Ditto for the renaming here.
5 years, 10 months ago (2015-01-30 12:07:58 UTC) #4
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-01-30 20:12:22 UTC) #7
msramek
5 years, 10 months ago (2015-02-03 11:32:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889893002/80001
5 years, 10 months ago (2015-02-03 11:33:08 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 10 months ago (2015-02-03 12:40:17 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2b3079c96f41b136c66d787b3bfa39ee17084cd4 Cr-Commit-Position: refs/heads/master@{#314319}
5 years, 10 months ago (2015-02-03 12:41:47 UTC) #12
msramek
5 years, 10 months ago (2015-02-18 11:24:54 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/933273002/ by msramek@chromium.org.

The reason for reverting is: Setting the camera and microphone default content
settings currently cannot be shown in the UI and will not work exactly the way
an app developer might expect it to (due to interference with the MEDIASTREAM
content setting).

Reverting this patch until the UI is ready.
.

Powered by Google App Engine
This is Rietveld 408576698