Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889873004: Move Color Picker Plumbing From WebViewGuest to GuestViewBase (Closed)

Created:
5 years, 10 months ago by Fady Samuel
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Color Picker Plumbing From WebViewGuest to GuestViewBase This allows all GuestView types to have access to a color picker. BUG=451737 Committed: https://crrev.com/9549ee3bcbbcbc7a1c0e99de212587281a7c7af8 Cr-Commit-Position: refs/heads/master@{#314035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M extensions/browser/guest_view/guest_view_base.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
5 years, 10 months ago (2015-01-30 22:44:11 UTC) #2
not at google - send to devlin
lgtm :)
5 years, 10 months ago (2015-01-30 23:09:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889873004/1
5 years, 10 months ago (2015-01-30 23:10:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-31 00:10:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-31 00:11:29 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9549ee3bcbbcbc7a1c0e99de212587281a7c7af8
Cr-Commit-Position: refs/heads/master@{#314035}

Powered by Google App Engine
This is Rietveld 408576698