Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 889863002: update vector ics to handle megamorphic keyed loads (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

update vector ics to handle megamorphic keyed loads R=mvstanton@chromium.org BUG= Committed: https://crrev.com/74c00e93c5f1754eab0ddad0101fb6b0db0601f0 Cr-Commit-Position: refs/heads/master@{#26352}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : grokdump #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -41 lines) Patch
M src/code-stubs-hydrogen.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download
M src/heap/heap.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/ic.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/type-feedback-vector.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M src/type-feedback-vector.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M tools/v8heapconst.py View 1 2 3 3 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcarney
ptal
5 years, 10 months ago (2015-01-30 10:48:33 UTC) #2
mvstanton
Wow, broken grokdump! LGTM.
5 years, 10 months ago (2015-01-30 11:47:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889863002/60001
5 years, 10 months ago (2015-01-30 11:48:25 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-30 12:41:03 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 12:41:15 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/74c00e93c5f1754eab0ddad0101fb6b0db0601f0
Cr-Commit-Position: refs/heads/master@{#26352}

Powered by Google App Engine
This is Rietveld 408576698