Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: runtime/lib/simd128.cc

Issue 88983004: Support Bigint parameters in Int32x4 constructor (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/bigint_operations.h » ('j') | runtime/vm/object.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/simd128.cc
diff --git a/runtime/lib/simd128.cc b/runtime/lib/simd128.cc
index 2bda63293e7e01385bf7e80d5ef553661e41a71a..d52530b5e1659a40f5d3a87be1387fc16a3f50bc 100644
--- a/runtime/lib/simd128.cc
+++ b/runtime/lib/simd128.cc
@@ -406,10 +406,10 @@ DEFINE_NATIVE_ENTRY(Int32x4_fromInts, 5) {
GET_NON_NULL_NATIVE_ARGUMENT(Integer, y, arguments->NativeArgAt(2));
GET_NON_NULL_NATIVE_ARGUMENT(Integer, z, arguments->NativeArgAt(3));
GET_NON_NULL_NATIVE_ARGUMENT(Integer, w, arguments->NativeArgAt(4));
- int32_t _x = static_cast<int32_t>(x.AsInt64Value() & 0xFFFFFFFF);
- int32_t _y = static_cast<int32_t>(y.AsInt64Value() & 0xFFFFFFFF);
- int32_t _z = static_cast<int32_t>(z.AsInt64Value() & 0xFFFFFFFF);
- int32_t _w = static_cast<int32_t>(w.AsInt64Value() & 0xFFFFFFFF);
+ int32_t _x = static_cast<int32_t>(x.AsTruncatedUint32Value());
+ int32_t _y = static_cast<int32_t>(y.AsTruncatedUint32Value());
+ int32_t _z = static_cast<int32_t>(z.AsTruncatedUint32Value());
+ int32_t _w = static_cast<int32_t>(w.AsTruncatedUint32Value());
return Int32x4::New(_x, _y, _z, _w);
}
« no previous file with comments | « no previous file | runtime/vm/bigint_operations.h » ('j') | runtime/vm/object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698