Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 889803003: Use style invalidation for :-webkit-any-link. (Closed)

Created:
5 years, 10 months ago by rune
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use style invalidation for :-webkit-any-link. We did not use an invalidation set for the PseudoAnyLink, and we didn't do a SubtreeStyleChange on link changes either, so when no :link or :visited selectors were present, the link style was not updated when the href was changed. Start using an invalidation set and updatePseudoState for PseudoAnyLink. R=esprehn@chromium.org BUG=453314 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189327

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
A LayoutTests/fast/css/invalidation/any-link-pseudo.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/any-link-pseudo-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
rune
PTAL
5 years, 10 months ago (2015-01-30 12:49:07 UTC) #1
esprehn
lgtm https://codereview.chromium.org/889803003/diff/1/Source/core/html/HTMLAnchorElement.cpp File Source/core/html/HTMLAnchorElement.cpp (right): https://codereview.chromium.org/889803003/diff/1/Source/core/html/HTMLAnchorElement.cpp#newcode200 Source/core/html/HTMLAnchorElement.cpp:200: pseudoStateChanged(CSSSelector::PseudoAnyLink); Hopefully doing this tree times isn't too ...
5 years, 10 months ago (2015-02-01 14:41:49 UTC) #2
esprehn
btw you'll probably need to merge this to the release branch.
5 years, 10 months ago (2015-02-01 14:42:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889803003/1
5 years, 10 months ago (2015-02-02 09:06:09 UTC) #5
rune
On 2015/02/01 14:41:49, esprehn wrote: > lgtm > > https://codereview.chromium.org/889803003/diff/1/Source/core/html/HTMLAnchorElement.cpp > File Source/core/html/HTMLAnchorElement.cpp (right): > ...
5 years, 10 months ago (2015-02-02 09:18:03 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 10:22:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189327

Powered by Google App Engine
This is Rietveld 408576698