Avoid WebSocket upgrade on network error.

Avoid WebSocket upgrade on network error.

In the event of network error, the WebSocket server response is not
validated. However, some network errors are ignored higher up in the
stack.

For example, in HttpNetworkTransaction::DoReadHeadersComplete at
http_network_transaction.cc:988, ERR_CONNECTION_CLOSED is converted to
OK.

To avoid this whole class of bugs, do not keep status code 101
(Switching Protocols) if there was a network error. It is changed to
503.

The response headers that are displayed in devtools are copied before
the change, so they will still retain the original status code.

BUG=408061
TEST=net_unittests

Committed: https://crrev.com/23c3f94ffbf774f240fbc52c08760b0e3d90964b
Cr-Commit-Position: refs/heads/master@{#314136}

[Adam Rice, 2015-01-30 02:26:22]

ricea@chromium.org changed reviewers:
+ yhirano@chromium.org

[yhirano, 2015-02-02 11:06:47]

lgtm

https://codereview.chromium.org/889783002/diff/1/net/websockets/websocket_bas...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/889783002/diff/1/net/websockets/websocket_bas...
net/websockets/websocket_basic_handshake_stream.cc:665:
HTTP_SWITCHING_PROTOCOLS)
[optional] This condition is not simple and the action is not short. I do prefer
using curly braces in this case.

[Adam Rice, 2015-02-02 12:10:26]

https://codereview.chromium.org/889783002/diff/1/net/websockets/websocket_bas...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/889783002/diff/1/net/websockets/websocket_bas...
net/websockets/websocket_basic_handshake_stream.cc:665:
HTTP_SWITCHING_PROTOCOLS)
On 2015/02/02 11:06:47, yhirano wrote:
> [optional] This condition is not simple and the action is not short. I do
prefer
> using curly braces in this case.

Done. Thanks.

[Adam Rice, 2015-02-02 12:10:54]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2015-02-02 12:11:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/889783002/20001

[commit-bot: I haz the power, 2015-02-02 13:35:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-02 13:38:02]

Patchset 2 (id:??) landed as
https://crrev.com/23c3f94ffbf774f240fbc52c08760b0e3d90964b
Cr-Commit-Position: refs/heads/master@{#314136}