Start moving ownership of SyncNotificationController to SyncController.

Start moving ownership of SyncNotificationController to SyncController.

GoogleServicesNotificationController is modified to work
the way most other singleton classes work, so that it is
not necessary to pass into the SyncNotificationController
constructor (and thus, into SyncController in the future).

SyncController gets a temporary setter method so that SNC
can be constructed downstream and passed in until all its
dependencies are upstream.

BUG=428882
Committed: https://crrev.com/deaa0fe6ca3e0428a85fc22b019819437d84120b
Cr-Commit-Position: refs/heads/master@{#314515}

[maxbogue, 2015-01-30 01:45:48]

maxbogue@chromium.org changed reviewers:
+ nyquist@chromium.org

[maxbogue, 2015-01-30 01:45:48]

PTAL! See the upstreaming doc for an overview of the whole plan for this.

[nyquist, 2015-02-03 18:32:34]

https://codereview.chromium.org/889723002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/GoogleServicesNotificationController.java
(right):

https://codereview.chromium.org/889723002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/notifications/GoogleServicesNotificationController.java:109:
public void overrideNotificationManagerForTests(NotificationManagerProxy
managerProxy) {
Oh my... Someone was lazy downstream by previously calling this method as a
member method instead of a static function. Lucky you who don't have to keep
something around!

[nyquist, 2015-02-03 18:32:40]

lgtm

[maxbogue, 2015-02-03 22:37:23]

I'm gonna need to rebase this after http://crrev.com/887143002 lands.

https://codereview.chromium.org/889723002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/GoogleServicesNotificationController.java
(right):

https://codereview.chromium.org/889723002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/notifications/GoogleServicesNotificationController.java:109:
public void overrideNotificationManagerForTests(NotificationManagerProxy
managerProxy) {
On 2015/02/03 18:32:34, nyquist wrote:
> Oh my... Someone was lazy downstream by previously calling this method as a
> member method instead of a static function. Lucky you who don't have to keep
> something around!

Yes, it was very convenient.

[maxbogue, 2015-02-04 06:37:33]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2015-02-04 06:38:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/889723002/40001

[commit-bot: I haz the power, 2015-02-04 07:14:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-04 07:16:08]

Patchset 3 (id:??) landed as
https://crrev.com/deaa0fe6ca3e0428a85fc22b019819437d84120b
Cr-Commit-Position: refs/heads/master@{#314515}

[perezju, 2015-02-04 10:55:35]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/895373002/ by perezju@chromium.org.

The reason for reverting is: Broke downstream builds.