Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889703004: dart2js: emit tear-offs in new emitter. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: emit tear-offs in new emitter. Depends on https://codereview.chromium.org/886903003/

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix rename. #

Total comments: 1

Patch Set 4 : Incorporated Stephan's CL + fixes. #

Total comments: 3

Patch Set 5 : WIP. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -104 lines) Patch
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 2 3 4 1 chunk +98 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 2 3 4 7 chunks +73 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart View 1 2 3 4 1 chunk +0 lines, -85 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 2 3 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
Started work on emitting tear-offs. It's very early WIP, but maybe you can already continue ...
5 years, 10 months ago (2015-01-30 00:01:47 UTC) #2
zarah
LGTM https://codereview.chromium.org/889703004/diff/40001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/889703004/diff/40001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode450 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:450: return ([method]..addAll(method.parameterStubs)).expand(makeNameCodePair); long line.
5 years, 10 months ago (2015-01-30 14:24:23 UTC) #3
floitsch
Incorporated Stephan's CL: https://chromiumcodereview.appspot.com/890893002/ Fixed intercepted methods (in a hackish way). Still needs cleanups.
5 years, 10 months ago (2015-01-30 23:44:50 UTC) #4
zarah
5 years, 10 months ago (2015-02-02 08:20:11 UTC) #5 
A few comments (probably the cleanups you would do anyway).

https://codereview.chromium.org/889703004/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/889703004/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:417: if (desc
instanceof Array) {
It would be nice with a comment here describing the encoding or a pointer to
somewhere else where it is described.

https://codereview.chromium.org/889703004/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:469: return
([method]..addAll(method.parameterStubs)).expand(makeNameCodePair);
long line.

https://codereview.chromium.org/889703004/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/889703004/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:2332: reflectionInfo is List ?
JSArray.markFixedList(reflectionInfo) : reflectionInfo,
long line.

Powered by Google App Engine
This is Rietveld 408576698