Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: pnacl/driver/pnacl-translate.py

Issue 889703003: Update comments referring to Chromium-side src/trusted/plugin code (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « SConstruct ('k') | src/trusted/service_runtime/env_cleanser.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pnacl/driver/pnacl-translate.py
diff --git a/pnacl/driver/pnacl-translate.py b/pnacl/driver/pnacl-translate.py
index 60e59064e7bbc8a2743ad29f419be388fab15c0c..60e2962c13a372e75be1a8b7217e590f640b4c7c 100755
--- a/pnacl/driver/pnacl-translate.py
+++ b/pnacl/driver/pnacl-translate.py
@@ -90,7 +90,7 @@ EXTRA_ENV = {
# BE CAREFUL: anything added here can introduce skew between
# the pnacl-translate commandline tool and the in-browser translator.
# See: llvm/tools/pnacl-llc/srpc_main.cpp and
- # chromium/src/ppapi/native_client/src/trusted/plugin/pnacl_options.cc
+ # Chromium's plugin/pnacl_translate_thread.cc
'LLC_FLAGS_COMMON': '${PIC ? -relocation-model=pic} ' +
# -force-tls-non-pic makes the code generator (llc)
# do the work that would otherwise be done by
@@ -105,7 +105,7 @@ EXTRA_ENV = {
# BE CAREFUL: anything added here can introduce skew between
# the pnacl-translate commandline tool and the in-browser translator.
# See: llvm/tools/pnacl-llc/srpc_main.cpp and
- # chromium/src/ppapi/native_client/src/trusted/plugin/pnacl_options.cc
+ # Chromium's plugin/pnacl_translate_thread.cc
'LLC_FLAGS_EXTRA' : '${FAST_TRANSLATION ? ${LLC_FLAGS_FAST}} ' +
'${#OPT_LEVEL ? -O${OPT_LEVEL}} ' +
'${OPT_LEVEL == 0 ? -disable-fp-elim}',
@@ -155,7 +155,7 @@ TranslatorPatterns = [
# BE CAREFUL: anything added here can introduce skew between
# the pnacl-translate commandline tool and the in-browser translator.
# See: llvm/tools/pnacl-llc/srpc_main.cpp and
- # chromium/src/ppapi/native_client/src/trusted/plugin/pnacl_options.cc
+ # Chromium's plugin/pnacl_translate_thread.cc
( '(-sfi-.+)', "env.append('LLC_FLAGS_EXTRA', $0)"),
( '(-mtls-use-call)', "env.append('LLC_FLAGS_EXTRA', $0)"),
( '(-force-align-stack)', "env.append('LLC_FLAGS_EXTRA', $0)"),
« no previous file with comments | « SConstruct ('k') | src/trusted/service_runtime/env_cleanser.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698