Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 889663003: Renamed GetMessage into GetNextMessage. (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
Reviewers:
agl, Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed GetMessage into GetNextMessage. Windows defines GetMessage as GetMessageW. This makes linking fail if p224_spake included after windows headers. NOPRESUBMIT=true Committed: https://crrev.com/d120360c6836854d4536969df71a1ca3b0d4073e Cr-Commit-Position: refs/heads/master@{#313782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M crypto/p224_spake.h View 3 chunks +7 lines, -7 lines 0 comments Download
M crypto/p224_spake.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M crypto/p224_spake_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/protocol/v2_authenticator.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-01-29 19:03:48 UTC) #2
Wez
lgtm
5 years, 10 months ago (2015-01-29 19:11:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889663003/1
5 years, 10 months ago (2015-01-29 19:12:15 UTC) #5
agl
lgtm
5 years, 10 months ago (2015-01-29 19:12:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 20:50:18 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:52:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d120360c6836854d4536969df71a1ca3b0d4073e
Cr-Commit-Position: refs/heads/master@{#313782}

Powered by Google App Engine
This is Rietveld 408576698