Upstream the iOS WebClient

Upstream the iOS WebClient

Committed: https://crrev.com/7b613d01da37186001f542ce9a9341d6cd3cd8ce
Cr-Commit-Position: refs/heads/master@{#313899}

[droger, 2015-01-30 09:47:08]

droger@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2015-01-30 10:29:46]

RS LGTM with comments

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.cc
File ios/web/public/web_client.cc (right):

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.cc...
ios/web/public/web_client.cc:21: WebClient::~WebClient() {
nit: please separate them with an empty line

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.h
File ios/web/public/web_client.h (right):

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.h#...
ios/web/public/web_client.h:39: WebClient* GetWebClient();
Please document this method.

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.h#...
ios/web/public/web_client.h:52: virtual void PreWebViewCreation() const {};
style: remove ";" after "{}" (here and everywhere else).

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.h#...
ios/web/public/web_client.h:84: // Return the contents of a resource in a
StringPiece given the resource id.
nit: Returns

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.h#...
ios/web/public/web_client.h:102: // singeleton.
nit: singleton

[droger, 2015-01-30 10:36:53]

Thanks for the review!

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.h
File ios/web/public/web_client.h (right):

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.h#...
ios/web/public/web_client.h:39: WebClient* GetWebClient();
On 2015/01/30 10:29:46, sdefresne wrote:
> Please document this method.

It's documented on line 35, I removed the blank line to make this clearer.

https://codereview.chromium.org/889663002/diff/1/ios/web/public/web_client.h#...
ios/web/public/web_client.h:52: virtual void PreWebViewCreation() const {};
On 2015/01/30 10:29:46, sdefresne wrote:
> style: remove ";" after "{}" (here and everywhere else).

Done.

[droger, 2015-01-30 10:36:56]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2015-01-30 10:37:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/889663002/20001

[commit-bot: I haz the power, 2015-01-30 11:23:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-30 11:25:02]

Patchset 2 (id:??) landed as
https://crrev.com/7b613d01da37186001f542ce9a9341d6cd3cd8ce
Cr-Commit-Position: refs/heads/master@{#313899}