Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: src/IceELFSection.cpp

Issue 889613004: Track undefined sym in the symtab. Remove hack for missing relocs against undef. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: separate asserts Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceELFSection.h ('k') | src/IceGlobalContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceELFSection.cpp
diff --git a/src/IceELFSection.cpp b/src/IceELFSection.cpp
index f6fb526a2dcab01fa91639ae09e9d33a42a577b8..f2e129d3e6e7a8c8dcc7ea24d90fcd067e082cc8 100644
--- a/src/IceELFSection.cpp
+++ b/src/IceELFSection.cpp
@@ -74,18 +74,8 @@ void ELFRelocationSection::addRelocations(RelocOffsetT BaseOff,
}
}
-size_t ELFRelocationSection::getSectionDataSize(
- const GlobalContext &Ctx, const ELFSymbolTableSection *SymTab) const {
- size_t NumWriteableRelocs = 0;
- for (const AssemblerFixup &Fixup : Fixups) {
- const ELFSym *Symbol = SymTab->findSymbol(Fixup.symbol(&Ctx));
- // TODO(jvoung): When the symbol table finally tracks everything,
- // just use the Fixups.size() as the count, and remove the
- // SymTab and Ctx params.
- if (Symbol)
- ++NumWriteableRelocs;
- }
- return NumWriteableRelocs * Header.sh_entsize;
+size_t ELFRelocationSection::getSectionDataSize() const {
+ return Fixups.size() * Header.sh_entsize;
}
// Symbol tables.
« no previous file with comments | « src/IceELFSection.h ('k') | src/IceGlobalContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698