Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889603008: include vector header (Closed)

Created:
5 years, 10 months ago by Mostyn Bramley-Moore
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include vector header Drive-by fixup for https://codereview.chromium.org/799633007 BUG=368298 Committed: https://crrev.com/92b4dad011619c15390a16e1b02750ae8d887d4a Cr-Commit-Position: refs/heads/master@{#315994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mostyn Bramley-Moore
@dmazzoni: I noticed you forgot to #include <vector> in a recent patch, PTAL at this ...
5 years, 10 months ago (2015-02-06 10:43:13 UTC) #2
Mostyn Bramley-Moore
@David: perhaps you can give this a thumbs-up?
5 years, 10 months ago (2015-02-11 23:13:15 UTC) #4
dmazzoni
lgtm Sorry for the delay and thanks for the fix.
5 years, 10 months ago (2015-02-12 16:28:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889603008/1
5 years, 10 months ago (2015-02-12 16:28:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 17:39:49 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 17:40:49 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/92b4dad011619c15390a16e1b02750ae8d887d4a
Cr-Commit-Position: refs/heads/master@{#315994}

Powered by Google App Engine
This is Rietveld 408576698