chrome/browser/resources/pdf/pdf_scripting_api.js - Issue 889603005: Prevent the PDF iframe from being tab-focusable in print preview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/pdf_scripting_api.js

Issue 889603005: Prevent the PDF iframe from being tab-focusable in print preview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/pdf/pdf_scripting_api.js

diff --git a/chrome/browser/resources/pdf/pdf_scripting_api.js b/chrome/browser/resources/pdf/pdf_scripting_api.js

index 03f14de64b5ab03f585a70932ed494f9ac1a9d31..c0b06d19221f51da2bf076dd919747c147f2e82e 100644

--- a/chrome/browser/resources/pdf/pdf_scripting_api.js

+++ b/chrome/browser/resources/pdf/pdf_scripting_api.js

@@ -263,6 +263,8 @@ function PDFCreateOutOfProcessPlugin(src) {

iframe.setAttribute(

'src',

'chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?' + src);

+ // Prevent the frame from being tab-focusable.

+ iframe.setAttribute('tabindex', '-1');

var client = new PDFScriptingAPI(window);

iframe.onload = function() {

client.setPlugin(iframe.contentWindow);

« no previous file with comments | « no previous file | no next file » | no next file with comments »