Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 889603003: Delete old ScreenOrientationDelegte (Closed)

Created:
5 years, 10 months ago by jonross
Modified:
5 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete old ScreenOrientationDelegte In the rename from ScreenOrientationDelegte to ScreenOrientationController, apparently one of the files was not properly deleted. It is no longer referenced anywhere, so I'm deleting it as intended. BUG=396760 Committed: https://crrev.com/ef8631fa2d396dd0f365d492fda5eb5dafec3917 Cr-Commit-Position: refs/heads/master@{#313773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -180 lines) Patch
D ash/content/display/screen_orientation_delegate_chromeos.cc View 1 chunk +0 lines, -180 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jonross
Hi Oshima, Apparently when I renamed the screen orientation files one was not properly deleted. ...
5 years, 10 months ago (2015-01-29 15:28:23 UTC) #2
oshima
lgtm
5 years, 10 months ago (2015-01-29 15:29:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889603003/1
5 years, 10 months ago (2015-01-29 19:47:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 20:22:39 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:25:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef8631fa2d396dd0f365d492fda5eb5dafec3917
Cr-Commit-Position: refs/heads/master@{#313773}

Powered by Google App Engine
This is Rietveld 408576698