Animate the app list search box shadow.

Animate the app list search box shadow.

This CL animates the app list search box shadow as it transitions from
any page to the search result page.

BUG=453653
Committed: https://crrev.com/1e04aae816f6ac47f30a29fb3b0e2531216a8686
Cr-Commit-Position: refs/heads/master@{#315260}

[calamity, 2015-02-05 06:38:11]

Patchset #1 (id:1) has been deleted

[calamity, 2015-02-05 06:38:22]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2015-02-06 04:32:27]

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/conten...
File ui/app_list/views/contents_animator.cc (right):

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/conten...
ui/app_list/views/contents_animator.cc:25: return
SearchBoxView::GetShadowForZHeight(1);
state == SSR ? 1 : 2

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
File ui/app_list/views/search_box_view.cc (right):

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:209: if (z_height == 1) {
How about

switch (z_height) {
  case 1:
  case 2:
  default:
}

(Still keeping the <= 0 case at the front.)

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:215: return gfx::ShadowValue(gfx::Point(0,
2), 4, SkColorSetARGB(0x33, 0, 0, 0));
Without going all the way of defining new constants for these values, can we at
least make them dependent on the constants?

gfx::ShadowValue(gfx::Point(0, kCardShadowYOffset * 2), kCardShadowBlur * 2,
SkColorSetARGB(0x33, 0, 0, 0));

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:217: return gfx::ShadowValue(gfx::Point(0,
8), 12, SkColorSetARGB(0x3F, 0, 0, 0));
Is this ever used?

[calamity, 2015-02-06 05:17:51]

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/conten...
File ui/app_list/views/contents_animator.cc (right):

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/conten...
ui/app_list/views/contents_animator.cc:25: return
SearchBoxView::GetShadowForZHeight(1);
On 2015/02/06 04:32:27, Matt Giuca wrote:
> state == SSR ? 1 : 2

Done.

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
File ui/app_list/views/search_box_view.cc (right):

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:209: if (z_height == 1) {
On 2015/02/06 04:32:27, Matt Giuca wrote:
> How about
> 
> switch (z_height) {
>   case 1:
>   case 2:
>   default:
> }
> 
> (Still keeping the <= 0 case at the front.)

Kay.

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:215: return gfx::ShadowValue(gfx::Point(0,
2), 4, SkColorSetARGB(0x33, 0, 0, 0));
On 2015/02/06 04:32:27, Matt Giuca wrote:
> Without going all the way of defining new constants for these values, can we
at
> least make them dependent on the constants?ShadowBor
> 
> gfx::ShadowValue(gfx::Point(0, kCardShadowYOffset * 2), kCardShadowBlur * 2,
> SkColorSetARGB(0x33, 0, 0, 0));

I don't think this necessarily a good idea. How about moving this whole function
to app_list_constants.cc? Also, since sky made me remove the other ShadowBorder
constructor, I can delete all the cardshadow constants and just leave it defined
inside this function.

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:217: return gfx::ShadowValue(gfx::Point(0,
8), 12, SkColorSetARGB(0x3F, 0, 0, 0));
On 2015/02/06 04:32:27, Matt Giuca wrote:
> Is this ever used?

Nope. It's the 'touch' one in the mocks. I guess we can add it back later..? I
was thinking of moving this whole function to app_list_constants.cc. Then it
kind of makes sense to leave this here since it's the UI-approved shadow value.
Or we can remove it.

[Matt Giuca, 2015-02-06 05:42:18]

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
File ui/app_list/views/search_box_view.cc (right):

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:215: return gfx::ShadowValue(gfx::Point(0,
2), 4, SkColorSetARGB(0x33, 0, 0, 0));
OK move it to app_list_constants and then it's justified to have all magic
numbers inside this function.

https://codereview.chromium.org/889593003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:217: return gfx::ShadowValue(gfx::Point(0,
8), 12, SkColorSetARGB(0x3F, 0, 0, 0));
If it's moved to ALC, then just leave this here.

[calamity, 2015-02-06 05:49:00]

Already done lol.

[Matt Giuca, 2015-02-06 06:12:23]

lgtm

[calamity, 2015-02-06 06:23:16]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-02-06 06:24:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/889593003/60001

[commit-bot: I haz the power, 2015-02-06 06:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 06:26:55]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[calamity, 2015-02-09 02:28:22]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-02-09 02:28:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/889593003/60001

[commit-bot: I haz the power, 2015-02-09 03:16:35]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-02-09 03:17:11]

Patchset 3 (id:??) landed as
https://crrev.com/1e04aae816f6ac47f30a29fb3b0e2531216a8686
Cr-Commit-Position: refs/heads/master@{#315260}