chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs - Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix copyright year. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/braille_util.js ('k') | chrome/browser/resources/chromeos/chromevox/common/editable_text.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

diff --git a/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs b/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

index 11cdf72468fcbaae4d1b654dc45cf353b79acb23..a1ee77ff9f44c3e59289f9cd834ed9a577a2982f 100644

--- a/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

+++ b/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

@@ -389,32 +389,32 @@ TEST_F('CvoxBrailleUtilUnitTest', 'CreateValue', function() {

// Value without a selection.

s = cvox.BrailleUtil.createValue('value');

assertEquals('value', s.toString());

- assertUndefined(s.getSpanInstanceOf(cvox.BrailleUtil.ValueSelectionSpan));

- valueSpan = s.getSpanInstanceOf(cvox.BrailleUtil.ValueSpan);

+ assertUndefined(s.getSpanInstanceOf(cvox.ValueSelectionSpan));

+ valueSpan = s.getSpanInstanceOf(cvox.ValueSpan);

assertEquals(0, s.getSpanStart(valueSpan));

assertEquals(s.getLength(), s.getSpanEnd(valueSpan));

// Value with a carret at the start of the text.

s = cvox.BrailleUtil.createValue('value', 0);

- selectionSpan = s.getSpanInstanceOf(cvox.BrailleUtil.ValueSelectionSpan);

+ selectionSpan = s.getSpanInstanceOf(cvox.ValueSelectionSpan);

assertEquals(0, s.getSpanStart(selectionSpan));

assertEquals(0, s.getSpanEnd(selectionSpan));

// Value with a carret inside the text.

s = cvox.BrailleUtil.createValue('value', 1);

- selectionSpan = s.getSpanInstanceOf(cvox.BrailleUtil.ValueSelectionSpan);

+ selectionSpan = s.getSpanInstanceOf(cvox.ValueSelectionSpan);

assertEquals(1, s.getSpanStart(selectionSpan));

assertEquals(1, s.getSpanEnd(selectionSpan));

// Value with a carret at the end of the text.

s = cvox.BrailleUtil.createValue('value', 5);

- selectionSpan = s.getSpanInstanceOf(cvox.BrailleUtil.ValueSelectionSpan);

+ selectionSpan = s.getSpanInstanceOf(cvox.ValueSelectionSpan);

assertEquals(5, s.getSpanStart(selectionSpan));

assertEquals(5, s.getSpanEnd(selectionSpan));

// All of the value selected selected with reversed start and end.

s = cvox.BrailleUtil.createValue('value', 5, 0);

- selectionSpan = s.getSpanInstanceOf(cvox.BrailleUtil.ValueSelectionSpan);

+ selectionSpan = s.getSpanInstanceOf(cvox.ValueSelectionSpan);

assertEquals(0, s.getSpanStart(selectionSpan));

assertEquals(5, s.getSpanEnd(selectionSpan));

});