Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2446)

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs

Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix copyright year. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs
diff --git a/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs b/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs
index 5afc9bccb9aaa9e739e742ee00c4dd8b2117e9e7..bd598dd6e272ea382d1df8039e19f66fc60ddfe0 100644
--- a/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs
+++ b/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs
@@ -18,10 +18,11 @@ CvoxExpandingBrailleTranslatorUnitTest.prototype = {
/** @override */
closureModuleDeps: [
- 'cvox.BrailleUtil',
'cvox.ExpandingBrailleTranslator',
'cvox.LibLouis',
'cvox.Spannable',
+ 'cvox.ValueSelectionSpan',
+ 'cvox.ValueSpan',
]
};
@@ -73,8 +74,8 @@ function assertArrayBufferMatches(expected, actual) {
TEST_F('CvoxExpandingBrailleTranslatorUnitTest', 'TranslationError',
function() {
- var text = new cvox.Spannable('error ok', new cvox.BrailleUtil.ValueSpan());
- text.setSpan(new cvox.BrailleUtil.ValueSelectionSpan, 0, 0);
+ var text = new cvox.Spannable('error ok', new cvox.ValueSpan());
+ text.setSpan(new cvox.ValueSelectionSpan, 0, 0);
var contractedTranslator = new FakeTranslator('c');
// Translator that always results in an error.
var uncontractedTranslator = {
@@ -199,11 +200,10 @@ function runTranslationTestVariants(testCase, contracted, valueExpansion) {
function createText(text, opt_selectionStart, opt_selectionEnd) {
var result = new cvox.Spannable(text);
- result.setSpan(
- new cvox.BrailleUtil.ValueSpan, 0, text.length);
+ result.setSpan(new cvox.ValueSpan, 0, text.length);
if (goog.isDef(opt_selectionStart)) {
result.setSpan(
- new cvox.BrailleUtil.ValueSelectionSpan,
+ new cvox.ValueSelectionSpan,
opt_selectionStart,
goog.isDef(opt_selectionEnd) ? opt_selectionEnd : opt_selectionStart);
}

Powered by Google App Engine
This is Rietveld 408576698