chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js - Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing dep and add a new one that should've been there already. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler_test.unitjs ('k') | chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs » ('j') | chrome/browser/resources/chromeos/chromevox/braille/spans.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js b/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

index 6d8b9f64ca347a9a7eb2aabecbd8324fd4a8a33b..bfab6c0ae07554feb5de645987139560113b9ca2 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

@@ -9,9 +9,10 @@

goog.provide('cvox.ExpandingBrailleTranslator');

-goog.require('cvox.BrailleUtil');

goog.require('cvox.LibLouis');

goog.require('cvox.Spannable');

+goog.require('cvox.ValueSelectionSpan');

+goog.require('cvox.ValueSpan');

/**

@@ -48,7 +49,7 @@ cvox.ExpandingBrailleTranslator =

/**

* What expansion to apply to the part of the translated string marked by the

- * {@code cvox.BrailleUtil.ValueSpan} spannable.

+ * {@code cvox.ValueSpan} spannable.

* @enum {number}

cvox.ExpandingBrailleTranslator.ExpansionType = {

@@ -200,7 +201,7 @@ cvox.ExpandingBrailleTranslator.prototype.findExpandRanges_ = function(

var result = [];

if (this.uncontractedTranslator_ &&

expansionType != cvox.ExpandingBrailleTranslator.ExpansionType.NONE) {

- var value = text.getSpanInstanceOf(cvox.BrailleUtil.ValueSpan);

+ var value = text.getSpanInstanceOf(cvox.ValueSpan);

if (value) {

// The below type casts are valid because the ranges must be valid when

// the span is known to exist.

@@ -234,8 +235,7 @@ cvox.ExpandingBrailleTranslator.prototype.findExpandRanges_ = function(

cvox.ExpandingBrailleTranslator.prototype.addRangesForSelection_ = function(

text, valueStart, valueEnd, outRanges) {

- var selection = text.getSpanInstanceOf(

- cvox.BrailleUtil.ValueSelectionSpan);

+ var selection = text.getSpanInstanceOf(cvox.ValueSelectionSpan);

if (!selection) {

return;

}