chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js - Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js

Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing dep and add a new one that should've been there already. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler_test.unitjs » ('j') | chrome/browser/resources/chromeos/chromevox/braille/spans.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js b/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js

index 04e99a38857d9fbcb9720a94584f1c4a973b37a3..1232d122ae98ac4f4374994d53305dfb98f632c8 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js

@@ -133,9 +133,8 @@ cvox.BrailleInputHandler.prototype.init = function() {

* spans.

cvox.BrailleInputHandler.prototype.onDisplayContentChanged = function(text) {

- var valueSpan = text.getSpanInstanceOf(cvox.BrailleUtil.ValueSpan);

- var selectionSpan = text.getSpanInstanceOf(

- cvox.BrailleUtil.ValueSelectionSpan);

+ var valueSpan = text.getSpanInstanceOf(cvox.ValueSpan);

+ var selectionSpan = text.getSpanInstanceOf(cvox.ValueSelectionSpan);

if (!(valueSpan && selectionSpan)) {

return;

}