Refactorings to reduce dependencies in ChromeVox 2.

Refactorings to reduce dependencies in ChromeVox 2.

Mainly, this breaks out braille span classes and the EditableTextBase
class into their own files.  This removes lots of dependencies on code that
should only run in the content script in ChromeVox classic from the
ChromeVox next background script.

BUG=

Committed: https://crrev.com/099889e8991773b0faf193d8e669d6151251f3d9
Cr-Commit-Position: refs/heads/master@{#313895}

[Peter Lundblad, 2015-01-29 15:44:46]

plundblad@chromium.org changed reviewers:
+ dtseng@chromium.org

[Peter Lundblad, 2015-01-29 15:44:46]

I started to sense deps hell here which we should try to avoid early on.

[David Tseng, 2015-01-29 18:48:38]

https://codereview.chromium.org/889593002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/braille/spans.js (right):

https://codereview.chromium.org/889593002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/braille/spans.js:1: // Copyright
2014 The Chromium Authors. All rights reserved.
nit: 2015
Also, I tried this a while ago and ran into some test failures related to unitjs
tests not picking up this file. I didn't dig in too deeply at the time, but
hoepfully, this doesn't happen to you.

https://codereview.chromium.org/889593002/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js
(right):

https://codereview.chromium.org/889593002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js:15:
goog.require('cvox.ChromeVox');
Why was this added?

[Peter Lundblad, 2015-01-29 21:08:39]

PTAL, new patchset uploaded.

dtseng@chromium.org writes:
> 
> 
> 
> 
>
https://codereview.chromium.org/889593002/diff/40001/chrome/browser/resources...
> File chrome/browser/resources/chromeos/chromevox/braille/spans.js
> (right):
> 
>
https://codereview.chromium.org/889593002/diff/40001/chrome/browser/resources...
> chrome/browser/resources/chromeos/chromevox/braille/spans.js:1: //
> Copyright 2014 The Chromium Authors. All rights reserved.
> nit: 2015

Done.

> Also, I tried this a while ago and ran into some test failures related
> to unitjs tests not picking up this file. I didn't dig in too deeply at
> the time, but hoepfully, this doesn't happen to you.

Didn't have any problems locally on the bots.  If this actually happens,
that indicates sme bug in our build rules and we should debug it.

>
https://codereview.chromium.org/889593002/diff/40001/chrome/browser/resources...
> File
>
chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js
> (right):
> 
>
https://codereview.chromium.org/889593002/diff/40001/chrome/browser/resources...
>
chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js:15:
> goog.require('cvox.ChromeVox');
> Why was this added?

Because cvox.ChromeVox is used by that file which was uncovered by my changes.

Thanks,
//Peter

> https://codereview.chromium.org/889593002/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2015-01-29 23:28:45]

lgtm



[Peter Lundblad, 2015-01-30 10:03:40]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2015-01-30 10:03:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/889593002/60001

[commit-bot: I haz the power, 2015-01-30 10:50:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-30 10:51:13]

Patchset 4 (id:??) landed as
https://crrev.com/099889e8991773b0faf193d8e669d6151251f3d9
Cr-Commit-Position: refs/heads/master@{#313895}