Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 889583005: Don't handle touch events in the OOP PDF plugin. (Closed)

Created:
5 years, 10 months ago by raymes
Modified:
5 years, 10 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't handle touch events in the OOP PDF plugin. We don't handle touch events in any special way in the plugin. Viewport operations all happen in the container page so we can skip handling them in the plugin. Committed: https://crrev.com/ffb9bd55ca4328556ca495b9661b42e9d76a42ea Cr-Commit-Position: refs/heads/master@{#314109}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M pdf/out_of_process_instance.cc View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 9 (2 generated)
raymes
5 years, 10 months ago (2015-01-30 05:21:11 UTC) #2
Sam McNally
https://codereview.chromium.org/889583005/diff/1/pdf/out_of_process_instance.cc File pdf/out_of_process_instance.cc (left): https://codereview.chromium.org/889583005/diff/1/pdf/out_of_process_instance.cc#oldcode281 pdf/out_of_process_instance.cc:281: RequestFilteringInputEvents(PP_INPUTEVENT_CLASS_TOUCH); Are touch events used for links?
5 years, 10 months ago (2015-01-30 06:04:51 UTC) #3
raymes
They seem to still work, probably because they get turned into mouse events. On Fri ...
5 years, 10 months ago (2015-02-02 01:13:26 UTC) #4
Sam McNally
lgtm
5 years, 10 months ago (2015-02-02 03:32:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889583005/1
5 years, 10 months ago (2015-02-02 03:34:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 08:12:54 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 08:13:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffb9bd55ca4328556ca495b9661b42e9d76a42ea
Cr-Commit-Position: refs/heads/master@{#314109}

Powered by Google App Engine
This is Rietveld 408576698