Issue 889583003: Remove 32-bit Mac implementation of EnableTerminationOnHeapCorruption().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 889583003: Remove 32-bit Mac implementation of EnableTerminationOnHeapCorruption(). (Closed)

Created:
5 years, 10 months ago by Robert Sesek

Modified:
5 years, 10 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove 32-bit Mac implementation of EnableTerminationOnHeapCorruption(). This removes CrMallocErrorBreak, since in 64-bit mode, Libc's malloc already makes this case fatal. BUG=453141 R=mark@chromium.org Committed: https://crrev.com/931d092bc54acfd92322f4d28a3d1c401f76c181 Cr-Commit-Position: refs/heads/master@{#313728}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -221 lines)			Patch
M	base/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base.gyp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	base/process/memory_mac.mm	View	14 chunks	+5 lines, -213 lines	0 comments	Download
M	base/process/memory_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889583003/1

5 years, 10 months ago (2015-01-29 17:17:04 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 17:23:19 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/931d092bc54acfd92322f4d28a3d1c401f76c181
Cr-Commit-Position: refs/heads/master@{#313728}