Source/core/html/forms/TextFieldInputType.cpp - Issue 889563002: Make RenderObject::style() return a const object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix a crashers (everything is building!) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/Element.cpp ('K') | « Source/core/html/forms/TextFieldInputType.h ('k') | Source/core/html/shadow/DetailsMarkerControl.h » ('j') | Source/core/rendering/TextAutosizer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/TextFieldInputType.cpp

diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp

index 9be541e24b28b93753d28523b51bb055e8cfdc63..9c3f0d83763c8f974b1fbda420786ba42e656997 100644

--- a/Source/core/html/forms/TextFieldInputType.cpp

+++ b/Source/core/html/forms/TextFieldInputType.cpp

@@ -64,7 +64,7 @@ private:

inline DataListIndicatorElement(Document& document) : HTMLDivElement(document) { }

inline HTMLInputElement* hostInput() const { return toHTMLInputElement(shadowHost()); }

- virtual RenderObject* createRenderer(RenderStyle*) override

+ virtual RenderObject* createRenderer(const RenderStyle*) override

{

return new RenderDetailsMarker(this);

}

@@ -267,7 +267,7 @@ bool TextFieldInputType::shouldSubmitImplicitly(Event* event)

return (event->type() == EventTypeNames::textInput && event->hasInterface(EventNames::TextEvent) && toTextEvent(event)->data() == "\n") || InputType::shouldSubmitImplicitly(event);

}

-RenderObject* TextFieldInputType::createRenderer(RenderStyle*) const

+RenderObject* TextFieldInputType::createRenderer(const RenderStyle*) const

{

return new RenderTextControlSingleLine(&element());

}