Source/core/svg/SVGStopElement.cpp - Issue 889563002: Make RenderObject::style() return a const object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGStopElement.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated change after Doug's review. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGStopElement.cpp

diff --git a/Source/core/svg/SVGStopElement.cpp b/Source/core/svg/SVGStopElement.cpp

index c356577c88500e2bf67a42ea58f04296d989ce74..bc72d65f06c43e639c5c2125433af65c041b7915 100644

--- a/Source/core/svg/SVGStopElement.cpp

+++ b/Source/core/svg/SVGStopElement.cpp

@@ -70,7 +70,7 @@ bool SVGStopElement::rendererIsNeeded(const LayoutStyle&)

Color SVGStopElement::stopColorIncludingOpacity() const

{

- LayoutStyle* style = renderer() ? renderer()->style() : 0;

+ const LayoutStyle* style = renderer() ? renderer()->style() : nullptr;

// FIXME: This check for null style exists to address Bug WK 90814, a rare crash condition in

// which the renderer or style is null. This entire class is scheduled for removal (Bug WK 86941)

// and we will tolerate this null check until then.