Source/core/layout/LayoutTextControlMultiLine.cpp - Issue 889563002: Make RenderObject::style() return a const object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTextControlMultiLine.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated change after Doug's review. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutTextControlMultiLine.cpp

diff --git a/Source/core/layout/LayoutTextControlMultiLine.cpp b/Source/core/layout/LayoutTextControlMultiLine.cpp

index 58d6b0b03f017e73ba2f615ee995757358b987ad..519f7b4755a4e4684df0e7c27f5c8d882025b362 100644

--- a/Source/core/layout/LayoutTextControlMultiLine.cpp

+++ b/Source/core/layout/LayoutTextControlMultiLine.cpp

@@ -94,7 +94,7 @@ LayoutObject* LayoutTextControlMultiLine::layoutSpecialExcludedChild(bool relayo

if (!placeholderRenderer->isBox())

return placeholderRenderer;

RenderBox* placeholderBox = toRenderBox(placeholderRenderer);

- placeholderBox->style()->setLogicalWidth(Length(contentLogicalWidth() - placeholderBox->borderAndPaddingLogicalWidth(), Fixed));

+ placeholderBox->mutableStyleRef().setLogicalWidth(Length(contentLogicalWidth() - placeholderBox->borderAndPaddingLogicalWidth(), Fixed));

placeholderBox->layoutIfNeeded();

placeholderBox->setX(borderLeft() + paddingLeft());

placeholderBox->setY(borderTop() + paddingTop());