Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: Source/core/dom/RenderTreeBuilder.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated change after Doug's review. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/PseudoElement.cpp ('k') | Source/core/dom/Text.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/RenderTreeBuilder.cpp
diff --git a/Source/core/dom/RenderTreeBuilder.cpp b/Source/core/dom/RenderTreeBuilder.cpp
index ce180e205b8abea53f2b589a082b6e8b0138de65..f4fafb9d14ca9d7f6d58917241a8913ec3c70e2b 100644
--- a/Source/core/dom/RenderTreeBuilder.cpp
+++ b/Source/core/dom/RenderTreeBuilder.cpp
@@ -149,12 +149,12 @@ void RenderTreeBuilderForElement::createRenderer()
void RenderTreeBuilderForText::createRenderer()
{
LayoutObject* parentRenderer = this->parentRenderer();
- LayoutStyle* style = parentRenderer->style();
+ LayoutStyle& style = parentRenderer->mutableStyleRef();
- ASSERT(m_node->textRendererIsNeeded(*style, *parentRenderer));
+ ASSERT(m_node->textRendererIsNeeded(style, *parentRenderer));
RenderText* newRenderer = m_node->createTextRenderer(style);
- if (!parentRenderer->isChildAllowed(newRenderer, *style)) {
+ if (!parentRenderer->isChildAllowed(newRenderer, style)) {
newRenderer->destroy();
return;
}
@@ -166,7 +166,7 @@ void RenderTreeBuilderForText::createRenderer()
LayoutObject* nextRenderer = this->nextRenderer();
m_node->setRenderer(newRenderer);
// Parent takes care of the animations, no need to call setAnimatableStyle.
- newRenderer->setStyle(style);
+ newRenderer->setStyle(&style);
parentRenderer->addChild(newRenderer, nextRenderer);
}
« no previous file with comments | « Source/core/dom/PseudoElement.cpp ('k') | Source/core/dom/Text.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698