Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: Source/core/html/HTMLSelectElement.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix a crashers (everything is building!) Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 bool HTMLSelectElement::shouldShowFocusRingOnMouseFocus() const 378 bool HTMLSelectElement::shouldShowFocusRingOnMouseFocus() const
379 { 379 {
380 return true; 380 return true;
381 } 381 }
382 382
383 bool HTMLSelectElement::canSelectAll() const 383 bool HTMLSelectElement::canSelectAll() const
384 { 384 {
385 return !usesMenuList(); 385 return !usesMenuList();
386 } 386 }
387 387
388 RenderObject* HTMLSelectElement::createRenderer(RenderStyle*) 388 RenderObject* HTMLSelectElement::createRenderer(const RenderStyle*)
389 { 389 {
390 if (usesMenuList()) 390 if (usesMenuList())
391 return new RenderMenuList(this); 391 return new RenderMenuList(this);
392 return new RenderListBox(this); 392 return new RenderListBox(this);
393 } 393 }
394 394
395 PassRefPtrWillBeRawPtr<HTMLCollection> HTMLSelectElement::selectedOptions() 395 PassRefPtrWillBeRawPtr<HTMLCollection> HTMLSelectElement::selectedOptions()
396 { 396 {
397 updateListItemSelectedStates(); 397 updateListItemSelectedStates();
398 return ensureCachedCollection<HTMLCollection>(SelectedOptions); 398 return ensureCachedCollection<HTMLCollection>(SelectedOptions);
(...skipping 1376 matching lines...) Expand 10 before | Expand all | Expand 10 after
1775 int focusedIndex = activeSelectionEndListIndex(); 1775 int focusedIndex = activeSelectionEndListIndex();
1776 if (focusedIndex < 0) 1776 if (focusedIndex < 0)
1777 focusedIndex = firstSelectableListIndex(); 1777 focusedIndex = firstSelectableListIndex();
1778 if (focusedIndex < 0) 1778 if (focusedIndex < 0)
1779 return nullptr; 1779 return nullptr;
1780 HTMLElement* focused = listItems()[focusedIndex]; 1780 HTMLElement* focused = listItems()[focusedIndex];
1781 return isHTMLOptionElement(focused) ? toHTMLOptionElement(focused) : nullptr ; 1781 return isHTMLOptionElement(focused) ? toHTMLOptionElement(focused) : nullptr ;
1782 } 1782 }
1783 1783
1784 } // namespace 1784 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698