Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: Source/core/svg/SVGFEFloodElement.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated change after Doug's review. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGElementRareData.cpp ('k') | Source/core/svg/SVGGraphicsElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 21 matching lines...) Expand all
32 : SVGFilterPrimitiveStandardAttributes(SVGNames::feFloodTag, document) 32 : SVGFilterPrimitiveStandardAttributes(SVGNames::feFloodTag, document)
33 { 33 {
34 } 34 }
35 35
36 DEFINE_NODE_FACTORY(SVGFEFloodElement) 36 DEFINE_NODE_FACTORY(SVGFEFloodElement)
37 37
38 bool SVGFEFloodElement::setFilterEffectAttribute(FilterEffect* effect, const Qua lifiedName& attrName) 38 bool SVGFEFloodElement::setFilterEffectAttribute(FilterEffect* effect, const Qua lifiedName& attrName)
39 { 39 {
40 LayoutObject* renderer = this->renderer(); 40 LayoutObject* renderer = this->renderer();
41 ASSERT(renderer); 41 ASSERT(renderer);
42 LayoutStyle* style = renderer->style(); 42 const LayoutStyle& style = renderer->styleRef();
43 ASSERT(style);
44 FEFlood* flood = static_cast<FEFlood*>(effect); 43 FEFlood* flood = static_cast<FEFlood*>(effect);
45 44
46 if (attrName == SVGNames::flood_colorAttr) 45 if (attrName == SVGNames::flood_colorAttr)
47 return flood->setFloodColor(style->svgStyle().floodColor()); 46 return flood->setFloodColor(style.svgStyle().floodColor());
48 if (attrName == SVGNames::flood_opacityAttr) 47 if (attrName == SVGNames::flood_opacityAttr)
49 return flood->setFloodOpacity(style->svgStyle().floodOpacity()); 48 return flood->setFloodOpacity(style.svgStyle().floodOpacity());
50 49
51 ASSERT_NOT_REACHED(); 50 ASSERT_NOT_REACHED();
52 return false; 51 return false;
53 } 52 }
54 53
55 PassRefPtrWillBeRawPtr<FilterEffect> SVGFEFloodElement::build(SVGFilterBuilder*, Filter* filter) 54 PassRefPtrWillBeRawPtr<FilterEffect> SVGFEFloodElement::build(SVGFilterBuilder*, Filter* filter)
56 { 55 {
57 LayoutObject* renderer = this->renderer(); 56 LayoutObject* renderer = this->renderer();
58 if (!renderer) 57 if (!renderer)
59 return nullptr; 58 return nullptr;
60 59
61 ASSERT(renderer->style()); 60 ASSERT(renderer->style());
62 const SVGLayoutStyle& svgStyle = renderer->style()->svgStyle(); 61 const SVGLayoutStyle& svgStyle = renderer->style()->svgStyle();
63 62
64 Color color = svgStyle.floodColor(); 63 Color color = svgStyle.floodColor();
65 float opacity = svgStyle.floodOpacity(); 64 float opacity = svgStyle.floodOpacity();
66 65
67 return FEFlood::create(filter, color, opacity); 66 return FEFlood::create(filter, color, opacity);
68 } 67 }
69 68
70 } 69 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGElementRareData.cpp ('k') | Source/core/svg/SVGGraphicsElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698