Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: Source/core/css/resolver/SharedStyleFinder.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated change after Doug's review. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 return false; 191 return false;
192 } 192 }
193 return true; 193 return true;
194 } 194 }
195 195
196 bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const 196 bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const
197 { 197 {
198 if (element() == candidate) 198 if (element() == candidate)
199 return false; 199 return false;
200 Element* parent = candidate.parentOrShadowHostElement(); 200 Element* parent = candidate.parentOrShadowHostElement();
201 LayoutStyle* style = candidate.layoutStyle(); 201 const LayoutStyle* style = candidate.layoutStyle();
202 if (!style) 202 if (!style)
203 return false; 203 return false;
204 if (!style->isSharable()) 204 if (!style->isSharable())
205 return false; 205 return false;
206 if (!parent) 206 if (!parent)
207 return false; 207 return false;
208 if (element().parentOrShadowHostElement()->layoutStyle() != parent->layoutSt yle()) 208 if (element().parentOrShadowHostElement()->layoutStyle() != parent->layoutSt yle())
209 return false; 209 return false;
210 if (candidate.tagQName() != element().tagQName()) 210 if (candidate.tagQName() != element().tagQName())
211 return false; 211 return false;
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 INCREMENT_STYLE_STATS_COUNTER(m_styleResolver, sharedStyleRejectedByUnco mmonAttributeRules); 337 INCREMENT_STYLE_STATS_COUNTER(m_styleResolver, sharedStyleRejectedByUnco mmonAttributeRules);
338 return 0; 338 return 0;
339 } 339 }
340 340
341 // Tracking child index requires unique style for each node. This may get se t by the sibling rule match above. 341 // Tracking child index requires unique style for each node. This may get se t by the sibling rule match above.
342 if (!element().parentElementOrShadowRoot()->childrenSupportStyleSharing()) { 342 if (!element().parentElementOrShadowRoot()->childrenSupportStyleSharing()) {
343 INCREMENT_STYLE_STATS_COUNTER(m_styleResolver, sharedStyleRejectedByPare nt); 343 INCREMENT_STYLE_STATS_COUNTER(m_styleResolver, sharedStyleRejectedByPare nt);
344 return 0; 344 return 0;
345 } 345 }
346 346
347 return shareElement->layoutStyle(); 347 return shareElement->mutableLayoutStyle();
348 } 348 }
349 349
350 } 350 }
OLDNEW
« no previous file with comments | « Source/core/css/resolver/ElementResolveContext.cpp ('k') | Source/core/css/resolver/StyleResolver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698