Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: Source/core/css/SelectorChecker.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated change after Doug's review. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/CSSGradientValue.cpp ('k') | Source/core/css/resolver/ElementResolveContext.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 607 matching lines...) Expand 10 before | Expand all | Expand 10 after
618 if (!textNode->data().isEmpty()) { 618 if (!textNode->data().isEmpty()) {
619 result = false; 619 result = false;
620 break; 620 break;
621 } 621 }
622 } 622 }
623 } 623 }
624 if (m_mode == ResolvingStyle) { 624 if (m_mode == ResolvingStyle) {
625 element.setStyleAffectedByEmpty(); 625 element.setStyleAffectedByEmpty();
626 if (context.elementStyle) 626 if (context.elementStyle)
627 context.elementStyle->setEmptyState(result); 627 context.elementStyle->setEmptyState(result);
628 else if (element.layoutStyle() && (element.document().styleEngin e()->usesSiblingRules() || element.layoutStyle()->unique())) 628 else if (element.mutableLayoutStyle() && (element.document().sty leEngine()->usesSiblingRules() || element.mutableLayoutStyle()->unique()))
629 element.layoutStyle()->setEmptyState(result); 629 element.mutableLayoutStyle()->setEmptyState(result);
630 } 630 }
631 return result; 631 return result;
632 } 632 }
633 case CSSSelector::PseudoFirstChild: 633 case CSSSelector::PseudoFirstChild:
634 // first-child matches the first child that is an element 634 // first-child matches the first child that is an element
635 if (ContainerNode* parent = element.parentElementOrDocumentFragment()) { 635 if (ContainerNode* parent = element.parentElementOrDocumentFragment()) {
636 bool result = siblingTraversalStrategy.isFirstChild(element); 636 bool result = siblingTraversalStrategy.isFirstChild(element);
637 if (m_mode == ResolvingStyle) { 637 if (m_mode == ResolvingStyle) {
638 parent->setChildrenAffectedByFirstChildRules(); 638 parent->setChildrenAffectedByFirstChildRules();
639 element.setAffectedByFirstChildRules(); 639 element.setAffectedByFirstChildRules();
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 return false; 695 return false;
696 return siblingTraversalStrategy.isFirstOfType(element, element.tagQN ame()) && siblingTraversalStrategy.isLastOfType(element, element.tagQName()); 696 return siblingTraversalStrategy.isFirstOfType(element, element.tagQN ame()) && siblingTraversalStrategy.isLastOfType(element, element.tagQName());
697 } 697 }
698 break; 698 break;
699 case CSSSelector::PseudoNthChild: 699 case CSSSelector::PseudoNthChild:
700 if (!selector.parseNth()) 700 if (!selector.parseNth())
701 break; 701 break;
702 if (ContainerNode* parent = element.parentElementOrDocumentFragment()) { 702 if (ContainerNode* parent = element.parentElementOrDocumentFragment()) {
703 int count = 1 + siblingTraversalStrategy.countElementsBefore(element ); 703 int count = 1 + siblingTraversalStrategy.countElementsBefore(element );
704 if (m_mode == ResolvingStyle) { 704 if (m_mode == ResolvingStyle) {
705 LayoutStyle* childStyle = context.elementStyle ? context.element Style : element.layoutStyle(); 705 const LayoutStyle* childStyle = context.elementStyle ? context.e lementStyle : element.layoutStyle();
706 if (childStyle) 706 if (childStyle)
707 childStyle->setUnique(); 707 childStyle->setUnique();
708 parent->setChildrenAffectedByForwardPositionalRules(); 708 parent->setChildrenAffectedByForwardPositionalRules();
709 } 709 }
710 710
711 if (selector.matchNth(count)) 711 if (selector.matchNth(count))
712 return true; 712 return true;
713 } 713 }
714 break; 714 break;
715 case CSSSelector::PseudoNthOfType: 715 case CSSSelector::PseudoNthOfType:
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
1186 return isHTMLSelectElement(element) && !toHTMLSelectElement(element).usesMen uList(); 1186 return isHTMLSelectElement(element) && !toHTMLSelectElement(element).usesMen uList();
1187 } 1187 }
1188 1188
1189 template 1189 template
1190 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const; 1190 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const;
1191 1191
1192 template 1192 template
1193 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const; 1193 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const;
1194 1194
1195 } 1195 }
OLDNEW
« no previous file with comments | « Source/core/css/CSSGradientValue.cpp ('k') | Source/core/css/resolver/ElementResolveContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698