Make RenderObject::style() return a const object

Source/web/mac/WebSubstringUtil.mm

 /*
  * Copyright (C) 2005, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 59 matching lines @@
         unsigned numCharacters = it.length();
         if (!numCharacters)
             continue;
 
         Node* container = it.startContainer();
         LayoutObject* renderer = container->renderer();
         ASSERT(renderer);
         if (!renderer)
             continue;
 
-        LayoutStyle* style = renderer->style();
-        NSFont* font = style->font().primaryFont()->getNSFont();
+        const LayoutStyle& style = renderer->styleRef();
+        NSFont* font = style.font().primaryFont()->getNSFont();
         // If the platform font can't be loaded, it's likely that the site is
         // using a web font. For now, just use the default font instead.
         // TODO(rsesek): Change the font activation flags to allow other processes
         // to use the font.
         if (!font)
-          font = [NSFont systemFontOfSize:style->font().fontDescription().computedSize()];
+          font = [NSFont systemFontOfSize:style.font().fontDescription().computedSize()];

[rune, 2015/02/10 12:03:01]

Correct indentation since you're changing this line?

[Julien - ping for review, 2015/02/10 23:10:43]

Done.

         [attrs setObject:font forKey:NSFontAttributeName];
 
-        if (style->visitedDependentColor(CSSPropertyColor).alpha())
-            [attrs setObject:nsColor(style->visitedDependentColor(CSSPropertyColor)) forKey:NSForegroundColorAttributeName];
+        if (style.visitedDependentColor(CSSPropertyColor).alpha())
+            [attrs setObject:nsColor(style.visitedDependentColor(CSSPropertyColor)) forKey:NSForegroundColorAttributeName];
         else
             [attrs removeObjectForKey:NSForegroundColorAttributeName];
-        if (style->visitedDependentColor(CSSPropertyBackgroundColor).alpha())
-            [attrs setObject:nsColor(style->visitedDependentColor(CSSPropertyBackgroundColor)) forKey:NSBackgroundColorAttributeName];
+        if (style.visitedDependentColor(CSSPropertyBackgroundColor).alpha())
+            [attrs setObject:nsColor(style.visitedDependentColor(CSSPropertyBackgroundColor)) forKey:NSBackgroundColorAttributeName];
         else
             [attrs removeObjectForKey:NSBackgroundColorAttributeName];
 
         Vector<UChar> characters;
         it.appendTextTo(characters);
         NSString* substring =
             [[[NSString alloc] initWithCharacters:characters.data()
                                            length:characters.size()] autorelease];
         [string replaceCharactersInRange:NSMakeRange(position, 0)
                               withString:substring];
@@ skipping 52 matching lines @@
     if (!editable)
         return nil;
     RefPtrWillBeRawPtr<Range> range(PlainTextRange(location, location + length).createRange(*editable));
     if (!range)
         return nil;
 
     return attributedSubstringFromRange(range.get());
 }
 
 } // namespace blink